French Polynesia
French Polynesia (FP) is my favorite destination for diving as it consistently delivers big animals, great visibility, and beautiful top side scenery. I also like that it isn't yet "touristy" and has much fewer people than most places.
If you are into sharks, then FP is the place to go. It is one of the few places left in the world where you can see lots of sharks on pretty much every dive. Dives can be either baited or non-baited, and you will see sharks either way. There is also a diversity of marine life and other common animals include dolphins, eagle rays, turtles, manta rays, barracuda, tuna, eels, and schools of jacks.
Coral is pretty healthy throughout the Tuamotu chain (Fakarava and Rangiroa) but not so much around the Society islands (Tahiti, Moorea, and Bora Bora).
For photography, wide angle and portrait will give the best opportunities and macro is limited.
Dive operators are plentiful and professional. Diving is land based and most dive sites are just minutes from the dive shop.
Food includes lots of fresh fish and fruit and has a French flair.
Beaches and top side scenery are breath-taking with the infinite multi-hued turquoise lagoons and white sandy beaches.
In my opinion, the only downside is that FP can be a bit pricey, especially on airfare.